Changing GtkBox:fill child property default back to TRUE.
authorTristan Van Berkom <tristan.van.berkom@gmail.com>
Thu, 25 Nov 2010 05:37:02 +0000 (14:37 +0900)
committerTristan Van Berkom <tristan.van.berkom@gmail.com>
Thu, 25 Nov 2010 05:37:02 +0000 (14:37 +0900)
Since Havoc's patches introducing the GtkWidget halign/valign
properties, fill should always be TRUE. If the widget should
not fill its allocated space then it should set the halign or
valign properties for that purpose.

This also consequently fixes bug 634592.

gtk/gtkbox.c

index 9786b3b4126463793d61904594aff8a7a1e1b000..e3c4b42e83e181e4b5b094286492d924d5ca377a 100644 (file)
@@ -274,17 +274,13 @@ gtk_box_class_init (GtkBoxClass *class)
    * GtkBox:fill:
    *
    * Whether the child should receive extra space when the parent grows.
-   *
-   * Note that the default value for this property is %FALSE for GtkBox,
-   * but #GtkHBox, #GtkVBox and other subclasses use the old default
-   * of %TRUE.
    */
   gtk_container_class_install_child_property (container_class,
                                              CHILD_PROP_FILL,
                                              g_param_spec_boolean ("fill",
                                                                    P_("Fill"),
                                                                    P_("Whether extra space given to the child should be allocated to the child or used as padding"),
-                                                                   FALSE,
+                                                                   TRUE,
                                                                    GTK_PARAM_READWRITE));
 
   gtk_container_class_install_child_property (container_class,
@@ -1648,7 +1644,7 @@ gtk_box_add (GtkContainer *container,
 
   gtk_box_pack_start (GTK_BOX (container), widget,
                       priv->default_expand,
-                      priv->default_expand,
+                      TRUE,
                       0);
 }